Page MenuHomePhabricator

Remove defunct "metamta.herald.show-hints" Config option
ClosedPublic

Authored by epriestley on Nov 24 2018, 2:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:26 AM
Unknown Object (File)
Fri, Apr 19, 2:57 AM
Unknown Object (File)
Thu, Apr 11, 12:35 AM
Unknown Object (File)
Thu, Mar 28, 3:29 PM
Unknown Object (File)
Mar 26 2024, 7:12 PM
Unknown Object (File)
Mar 19 2024, 10:47 PM
Unknown Object (File)
Mar 17 2024, 6:09 PM
Unknown Object (File)
Feb 3 2024, 8:00 PM
Subscribers
None

Details

Summary

Ref T13216. See PHI985. This config option once controlled adding a Herald transcript link to email. However, this was never implemented in a generic way and was removed from revisions in D8459 and from commits in D10705. No one has noticed or asked for this option for several years, so this is probably a good opportunity to simplify the software and reduce the total amount of configuration.

If we did want to pursue this in the future, I'd generally prefer to make it part of the mail detail page (/mail/detail/12345/) anyway.

Test Plan

Grepped for metamta.herald.show-hints and addHeraldSection(), got no hits for either.

Diff Detail

Repository
rP Phabricator
Branch
hhints1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21207
Build 28841: Run Core Tests
Build 28840: arc lint + arc unit