Paths

Table of Contentst

Differential D19820

Fix some "%Q" behavior in PhortuneMerchantQuery
ClosedPublic
Actions

Authored by epriestley on Nov 17 2018, 1:20 AM.

Tags

None

Referenced Files

	F18891239: D19820.diff
	Fri, Nov 7, 10:24 AM

	F18836162: D19820.id.diff
	Sun, Oct 26, 10:52 PM

	F18815404: D19820.diff
	Tue, Oct 21, 2:02 AM

	F18809494: D19820.id.diff
	Sun, Oct 19, 2:32 PM

	F18789058: D19820.id47334.diff
	Wed, Oct 15, 7:44 AM

	F18736574: D19820.id47340.diff
	Oct 1 2025, 6:45 AM

	F18733849: D19820.id.diff
	Sep 30 2025, 10:43 PM

	F18649399: D19820.diff
	Sep 20 2025, 8:21 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13217: Upgrading: Hardening of qsprintf()

Commits

rP4967cd6ab941: Fix some "%Q" behavior in PhortuneMerchantQuery

Summary

Ref T13217. This older query does some manual joins; update it for more modern joins.

Test Plan

Ran instances/ unit tests and got a clean result, browsed Phortune merchants.

Diff Detail

Repository

rP Phabricator

Branch

query13

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21185
Build 28805: Run Core Tests
Build 28804: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 17 2018, 1:20 AM

Harbormaster completed remote builds in B21185: Diff 47334.Nov 17 2018, 1:21 AM

epriestley requested review of this revision.Nov 17 2018, 1:21 AM

amckinley accepted this revision.Nov 19 2018, 4:11 PM

This revision is now accepted and ready to land.Nov 19 2018, 4:11 PM

Closed by commit rP4967cd6ab941: Fix some "%Q" behavior in PhortuneMerchantQuery (authored by epriestley). · Explain WhyNov 20 2018, 4:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phortune/

query/

PhortuneMerchantQuery.php

36 lines

Diff 47334

View Options

src/applications/phortune/query/PhortuneMerchantQuery.php

Fix some "%Q" behavior in PhortuneMerchantQueryClosedPublicActions