Paths

Table of Contentst

Differential D19820

Fix some "%Q" behavior in PhortuneMerchantQuery
ClosedPublic
Actions

Authored by epriestley on Nov 17 2018, 1:20 AM.

Tags

None

Referenced Files

	F18789058: D19820.id47334.diff
	Wed, Oct 15, 7:44 AM

	F18736574: D19820.id47340.diff
	Wed, Oct 1, 6:45 AM

	F18733849: D19820.id.diff
	Tue, Sep 30, 10:43 PM

	F18649399: D19820.diff
	Sat, Sep 20, 8:21 PM

	F18629540: D19820.diff
	Sep 16 2025, 9:11 AM

	F18568935: D19820.id47340.diff
	Sep 10 2025, 12:30 AM

	F18568929: D19820.id47334.diff
	Sep 10 2025, 12:30 AM

	F18509941: D19820.id.diff
	Sep 5 2025, 3:41 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13217: Upgrading: Hardening of qsprintf()

Commits

rP4967cd6ab941: Fix some "%Q" behavior in PhortuneMerchantQuery

Summary

Ref T13217. This older query does some manual joins; update it for more modern joins.

Test Plan

Ran instances/ unit tests and got a clean result, browsed Phortune merchants.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 17 2018, 1:20 AM

Harbormaster completed remote builds in B21185: Diff 47334.Nov 17 2018, 1:21 AM

epriestley requested review of this revision.Nov 17 2018, 1:21 AM

amckinley accepted this revision.Nov 19 2018, 4:11 PM

This revision is now accepted and ready to land.Nov 19 2018, 4:11 PM

Closed by commit rP4967cd6ab941: Fix some "%Q" behavior in PhortuneMerchantQuery (authored by epriestley). · Explain WhyNov 20 2018, 4:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phortune/

query/

PhortuneMerchantQuery.php

36 lines

Diff 47340

View Options

src/applications/phortune/query/PhortuneMerchantQuery.php

Fix some "%Q" behavior in PhortuneMerchantQueryClosedPublicActions