Paths

Table of Contentst

Differential D19803

Modernize the Herald rule search engine
ClosedPublic
Actions

Authored by epriestley on Nov 14 2018, 8:11 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13216: 2018 Week 45-47 Bonus Content

Commits

rPbbd292b9b34e: Modernize the Herald rule search engine

Summary

Ref T13216. Update the Herald Rule SearchEngine and Query to use a more modern style.

Test Plan

Ran various rule queries in the UI, got sensible results

Diff Detail

Repository

rP Phabricator

Branch

herald1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21144
Build 28745: Run Core Tests
Build 28744: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 14 2018, 8:11 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 14 2018, 8:11 PM

Harbormaster failed remote builds in B21144: Diff 47295!

Stacked on qsprintf() stuff.

amckinley accepted this revision.Nov 15 2018, 8:09 PM

amckinley added inline comments.

src/applications/herald/query/HeraldRuleSearchEngine.php
29–55	Wow, I didn't realize how much nicer the new-style search stuff looks!

This revision is now accepted and ready to land.Nov 15 2018, 8:09 PM

Closed by commit rPbbd292b9b34e: Modernize the Herald rule search engine (authored by epriestley). · Explain WhyNov 15 2018, 11:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

query/

HeraldRuleQuery.php

43 lines

HeraldRuleSearchEngine.php

142 lines

Diff 47295

View Options

src/applications/herald/query/HeraldRuleQuery.php