Page MenuHomePhabricator

Modernize the Herald rule search engine
ClosedPublic

Authored by epriestley on Wed, Nov 14, 8:11 PM.

Details

Summary

Ref T13216. Update the Herald Rule SearchEngine and Query to use a more modern style.

Test Plan

Ran various rule queries in the UI, got sensible results

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Nov 14, 8:11 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Nov 14, 8:11 PM
Harbormaster failed remote builds in B21144: Diff 47295!
epriestley requested review of this revision.Wed, Nov 14, 8:19 PM

Stacked on qsprintf() stuff.

amckinley accepted this revision.Thu, Nov 15, 8:09 PM
amckinley added inline comments.
src/applications/herald/query/HeraldRuleSearchEngine.php
29–55

Wow, I didn't realize how much nicer the new-style search stuff looks!

This revision is now accepted and ready to land.Thu, Nov 15, 8:09 PM
This revision was automatically updated to reflect the committed changes.