Page MenuHomePhabricator

Add Spaces support for Files
Changes PlannedPublicDraft

Authored by joshuaspence on Oct 31 2018, 11:35 PM.

Details

Reviewers
None
Group Reviewers
Blessed Reviewers
Summary

This doesn't work, but I'm just submitting it anyway in case I plan to finish working on it.

Test Plan

WIP

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint WarningsExcuse: WIP
SeverityLocationCodeMessage
Warningsrc/applications/files/engine/PhabricatorFileStorageEngine.php:156TXT3Line Too Long
Warningsrc/applications/files/storage/PhabricatorFile.php:243TXT3Line Too Long
Warningsrc/applications/files/storage/PhabricatorFile.php:331XHP60Default Parameters
Warningsrc/applications/files/storage/PhabricatorFile.php:447XHP60Default Parameters
Advicescripts/mail/mail_handler.php:80XHP16TODO Comment
Advicescripts/util/add_macro.php:51XHP16TODO Comment
Advicesrc/applications/differential/storage/DifferentialHunk.php:335XHP16TODO Comment
Advicesrc/applications/drydock/interface/filesystem/DrydockSFTPFilesystemInterface.php:49XHP16TODO Comment
Advicesrc/applications/files/engine/PhabricatorFileStorageEngine.php:156XHP16TODO Comment
Advicesrc/applications/files/favicon/PhabricatorFaviconRef.php:446XHP16TODO Comment
Advicesrc/applications/files/format/__tests__/PhabricatorFileStorageFormatTestCase.php:26XHP16TODO Comment
Advicesrc/applications/files/format/__tests__/PhabricatorFileStorageFormatTestCase.php:74XHP16TODO Comment
Advicesrc/applications/files/format/__tests__/PhabricatorFileStorageFormatTestCase.php:120XHP16TODO Comment
Advicesrc/applications/files/lipsum/PhabricatorFileTestDataGenerator.php:17XHP16TODO Comment
Advicesrc/applications/files/storage/PhabricatorFile.php:233XHP16TODO Comment
Advicesrc/applications/files/storage/PhabricatorFile.php:238XHP16TODO Comment
Advicesrc/applications/files/storage/PhabricatorFile.php:690XHP16TODO Comment
Advicesrc/applications/files/storage/PhabricatorFile.php:1208XHP16TODO Comment
Advicesrc/applications/files/storage/__tests__/PhabricatorFileTestCase.php:264XHP16TODO Comment
Advicesrc/applications/files/storage/__tests__/PhabricatorFileTestCase.php:289XHP16TODO Comment
Advicesrc/applications/files/storage/__tests__/PhabricatorFileTestCase.php:292XHP16TODO Comment
Advicesrc/applications/files/storage/__tests__/PhabricatorFileTestCase.php:320XHP16TODO Comment
Advicesrc/applications/files/storage/__tests__/PhabricatorFileTestCase.php:345XHP16TODO Comment
Advicesrc/applications/files/storage/__tests__/PhabricatorFileTestCase.php:372XHP16TODO Comment
Advicesrc/applications/files/storage/__tests__/PhabricatorFileTestCase.php:395XHP16TODO Comment
Unit
Unit Tests Skipped
Build Status
Buildable 21065
Build 28622: Run Core Tests
Build 28621: arc lint + arc unit

Event Timeline

joshuaspence created this revision.Oct 31 2018, 11:35 PM
Owners added a subscriber: Restricted Owners Package.Oct 31 2018, 11:35 PM
joshuaspence planned changes to this revision.Oct 31 2018, 11:35 PM