Page MenuHomePhabricator

Make the Harbormaster build plan edit engine forms configurable
AcceptedPublic

Authored by epriestley on Oct 16 2018, 7:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 12:47 AM
Unknown Object (File)
Wed, Mar 27, 12:47 AM
Unknown Object (File)
Wed, Mar 27, 12:44 AM
Unknown Object (File)
Feb 3 2024, 7:38 PM
Unknown Object (File)
Dec 27 2023, 12:52 PM
Unknown Object (File)
Dec 22 2023, 12:31 AM
Unknown Object (File)
Dec 13 2023, 6:10 AM
Unknown Object (File)
Nov 30 2023, 1:27 AM
Subscribers
Restricted Owners Package

Details

Summary

See PHI933. Ref T13210. Harbormaster build plans were convereted to EditEngine some time ago (see D15357) but the forms were not made configurable.

I believe this was just to avoid unnecessary complexity, and there's no reason not to allow configuration of these forms. In particular, support for form configuration allows you to set alternate default view/edit policies and add instructions.

PHI933 is a specific request for changing the default policies, and this is a reasonable approach to providing support.

Test Plan

Created a new build plan, edited build plan forms, changed form name, chagned form defaults, saw new defaults/name reflected in UI.

Diff Detail

Repository
rP Phabricator
Branch
plan1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21016
Build 28550: Run Core Tests
Build 28549: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Oct 16 2018, 7:48 PM

This is slightly more involved than I initially believed, we have a "Default Edit Policy" and "Default View Policy" which should probably be nuked now and PHI933 also has a sub-request for an "Author" object policy.

  • Let's move forward with this after all: although we need some more work to fix the "Default XYZ Policy" stuff, this is the best path forward for PHI1204 (which requests that build plan behaviors have configurable defaults).
This revision is now accepted and ready to land.Apr 17 2019, 5:33 PM