Page MenuHomePhabricator

Make the Harbormaster build plan edit engine forms configurable

Authored by epriestley on Oct 16 2018, 7:48 PM.



See PHI933. Ref T13210. Harbormaster build plans were convereted to EditEngine some time ago (see D15357) but the forms were not made configurable.

I believe this was just to avoid unnecessary complexity, and there's no reason not to allow configuration of these forms. In particular, support for form configuration allows you to set alternate default view/edit policies and add instructions.

PHI933 is a specific request for changing the default policies, and this is a reasonable approach to providing support.

Test Plan

Created a new build plan, edited build plan forms, changed form name, chagned form defaults, saw new defaults/name reflected in UI.

Diff Detail

rP Phabricator
Lint OK
Unit Tests OK
Build Status
Buildable 22577
Build 30926: Run Core Tests
Build 30925: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 16 2018, 7:48 PM
Owners added a subscriber: Restricted Owners Package.Oct 16 2018, 7:48 PM
epriestley requested review of this revision.Oct 16 2018, 7:49 PM
epriestley planned changes to this revision.Oct 16 2018, 8:19 PM

This is slightly more involved than I initially believed, we have a "Default Edit Policy" and "Default View Policy" which should probably be nuked now and PHI933 also has a sub-request for an "Author" object policy.

  • Let's move forward with this after all: although we need some more work to fix the "Default XYZ Policy" stuff, this is the best path forward for PHI1204 (which requests that build plan behaviors have configurable defaults).
amckinley accepted this revision.Apr 17 2019, 5:33 PM
This revision is now accepted and ready to land.Apr 17 2019, 5:33 PM