Differential D19732

Allow revisions to be filtered by created date
ClosedPublic
Actions

Authored by epriestley on Oct 5 2018, 6:14 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13202: Plans: 2018 Week 38-40 Bonus Content

Commits

rPc6c1893dc0be: Allow revisions to be filtered by created date

Summary

Ref T13202. See PHI906. This is a reasonable capability which we support in some other applications already.

(The only real reason not to support this is that it creates some clutter in the UI, but I think we're generally in better shape now than we were in the past, and we could make this UI collapse/fold at some point.)

Test Plan

Ran queries with a minimum date, a maximum date, both, and neither. Saw appropriate results in all cases.

Diff Detail

Repository

rP Phabricator

Branch

date1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20989
Build 28512: Run Core Tests
Build 28511: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 5 2018, 6:14 PM

Harbormaster completed remote builds in B20989: Diff 47149.Oct 5 2018, 6:15 PM

epriestley requested review of this revision.Oct 5 2018, 6:15 PM

amckinley accepted this revision.Oct 5 2018, 6:17 PM

This revision is now accepted and ready to land.Oct 5 2018, 6:17 PM

Closed by commit rPc6c1893dc0be: Allow revisions to be filtered by created date (authored by epriestley). · Explain WhyOct 5 2018, 7:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionQuery.php

22 lines

DifferentialRevisionSearchEngine.php

16 lines

Diff 47149

View Options

src/applications/differential/query/DifferentialRevisionQuery.php