Page MenuHomePhabricator

Add an explicit "max-width" to PHUIDocumentPro pages to force large tables to scroll
ClosedPublic

Authored by epriestley on Oct 1 2018, 6:08 PM.
Tags
None
Referenced Files
F15538197: D19723.id.diff
Thu, Apr 24, 6:00 PM
F15504718: D19723.id47122.diff
Mon, Apr 14, 7:56 PM
F15489532: D19723.id47119.diff
Fri, Apr 11, 9:38 AM
F15474870: D19723.diff
Sun, Apr 6, 1:03 PM
F15438718: D19723.id47122.diff
Mar 26 2025, 3:01 AM
F15438194: D19723.id47119.diff
Mar 25 2025, 11:42 PM
F15435877: D19723.id47119.diff
Mar 25 2025, 10:39 AM
F15433005: D19723.id.diff
Mar 24 2025, 8:50 PM
Subscribers
None

Details

Summary

Ref T13202. See https://discourse.phabricator-community.org/t/phriction-page-controls-lost-after-creating-very-wide-table/1961.

If you put a very wide table in the markup for a new-layout Phriction page, it can push the actions element off screen to the right.

Tables already get a scrollbar if encouraged strongly enough; add a max-width to encourage them.

Test Plan
  • Viewed pages with a large wrappable and non-wrappable content on mobile, tablet, and desktop.

Screen Shot 2018-10-01 at 11.06.29 AM.png (1×1 px, 144 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable