Page MenuHomePhabricator

Add an explicit "max-width" to PHUIDocumentPro pages to force large tables to scroll
ClosedPublic

Authored by epriestley on Oct 1 2018, 6:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 10:28 PM
Unknown Object (File)
Wed, Mar 20, 10:28 PM
Unknown Object (File)
Mon, Mar 11, 11:19 AM
Unknown Object (File)
Sun, Mar 10, 5:01 AM
Unknown Object (File)
Jan 31 2024, 2:05 PM
Unknown Object (File)
Jan 31 2024, 1:30 PM
Unknown Object (File)
Jan 31 2024, 12:29 PM
Unknown Object (File)
Jan 31 2024, 12:23 PM
Subscribers
None

Details

Summary

Ref T13202. See https://discourse.phabricator-community.org/t/phriction-page-controls-lost-after-creating-very-wide-table/1961.

If you put a very wide table in the markup for a new-layout Phriction page, it can push the actions element off screen to the right.

Tables already get a scrollbar if encouraged strongly enough; add a max-width to encourage them.

Test Plan
  • Viewed pages with a large wrappable and non-wrappable content on mobile, tablet, and desktop.

Screen Shot 2018-10-01 at 11.06.29 AM.png (1×1 px, 144 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable