Page MenuHomePhabricator

Add an explicit "max-width" to PHUIDocumentPro pages to force large tables to scroll
ClosedPublic

Authored by epriestley on Oct 1 2018, 6:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 6, 1:07 PM
Unknown Object (File)
Wed, Apr 30, 2:57 AM
Unknown Object (File)
Wed, Apr 30, 1:07 AM
Unknown Object (File)
Thu, Apr 24, 6:00 PM
Unknown Object (File)
Apr 14 2025, 7:56 PM
Unknown Object (File)
Apr 11 2025, 9:38 AM
Unknown Object (File)
Apr 6 2025, 1:03 PM
Unknown Object (File)
Mar 26 2025, 3:01 AM
Subscribers
None

Details

Summary

Ref T13202. See https://discourse.phabricator-community.org/t/phriction-page-controls-lost-after-creating-very-wide-table/1961.

If you put a very wide table in the markup for a new-layout Phriction page, it can push the actions element off screen to the right.

Tables already get a scrollbar if encouraged strongly enough; add a max-width to encourage them.

Test Plan
  • Viewed pages with a large wrappable and non-wrappable content on mobile, tablet, and desktop.

Screen Shot 2018-10-01 at 11.06.29 AM.png (1×1 px, 144 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable