Paths

Table of Contentst

Differential D19723

Add an explicit "max-width" to PHUIDocumentPro pages to force large tables to scroll
ClosedPublic
Actions

Authored by epriestley on Oct 1 2018, 6:08 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13202: Plans: 2018 Week 38-40 Bonus Content

Commits

rPcfd9fa7f559f: Add an explicit "max-width" to PHUIDocumentPro pages to force large tables to…

Summary

Ref T13202. See https://discourse.phabricator-community.org/t/phriction-page-controls-lost-after-creating-very-wide-table/1961.

If you put a very wide table in the markup for a new-layout Phriction page, it can push the actions element off screen to the right.

Tables already get a scrollbar if encouraged strongly enough; add a max-width to encourage them.

Test Plan

Viewed pages with a large wrappable and non-wrappable content on mobile, tablet, and desktop.

Screen Shot 2018-10-01 at 11.06.29 AM.png (1×1 px, 144 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 1 2018, 6:08 PM

Harbormaster completed remote builds in B20929: Diff 47119.Oct 1 2018, 6:09 PM

epriestley requested review of this revision.Oct 1 2018, 6:09 PM

amckinley accepted this revision.Oct 1 2018, 7:38 PM

This revision is now accepted and ready to land.Oct 1 2018, 7:38 PM

Closed by commit rPcfd9fa7f559f: Add an explicit "max-width" to PHUIDocumentPro pages to force large tables to… (authored by epriestley). · Explain WhyOct 1 2018, 8:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

css/

phui/

phui-document-pro.css

6 lines

Diff 47122

View Options

resources/celerity/map.php