Page MenuHomePhabricator
Differential D19712

[Wilds] Make "Base Commit" parser test cases pass
ClosedPublic
Actions

Authored by epriestley on Sep 27 2018, 5:33 PM.
Tags
None
Referenced Files
F15713564: D19712.id47106.diff
Thu, May 29, 4:25 AM
Unknown Object (File)
Mon, May 26, 2:55 AM
Unknown Object (File)
Fri, May 9, 3:36 PM
Unknown Object (File)
Fri, May 9, 8:28 AM
Unknown Object (File)
Tue, May 6, 11:28 AM
Unknown Object (File)
Apr 23 2025, 8:50 PM
Unknown Object (File)
Apr 7 2025, 5:56 AM
Unknown Object (File)
Apr 6 2025, 6:56 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13098: Plans: Arcanist toolsets and extensions
Commits
rARC964707ffdfa8: [Wilds] Make "Base Commit" parser test cases pass
Summary

Ref T13098. Chip away at test cases: update the tests for base rule parsing for the new WorkingCopy objects.

Test Plan

Ran arc unit, saw fewer test failures.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 20915
Build 28430: Run Core Tests

Event Timeline

epriestley requested review of this revision.Sep 27 2018, 5:33 PM
epriestley created this revision.
Harbormaster failed remote builds in B20915: Diff 47106!Sep 27 2018, 5:33 PM
amckinley accepted this revision.Sep 27 2018, 8:18 PM
This revision is now accepted and ready to land.Sep 27 2018, 8:18 PM
Closed by commit rARC964707ffdfa8: [Wilds] Make "Base Commit" parser test cases pass (authored by epriestley). · Explain WhyOct 1 2018, 11:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47106

View Options

src/parser/__tests__/ArcanistBaseCommitParserTestCase.php

Loading...
View Options

src/workingcopy/ArcanistGitWorkingCopy.php

Loading...
View Options

src/workingcopy/ArcanistMercurialWorkingCopy.php

Loading...
View Options

src/workingcopy/ArcanistSubversionWorkingCopy.php

Loading...
View Options

src/workingcopy/ArcanistWorkingCopy.php

Loading...
Phabricator · Built by Phacility