Page MenuHomePhabricator

[Wilds] Fix some minor classtree issues identified by unit tests
ClosedPublic

Authored by epriestley on Sep 25 2018, 10:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 14, 5:02 PM
Unknown Object (File)
Feb 18 2024, 6:11 PM
Unknown Object (File)
Feb 3 2024, 7:32 PM
Unknown Object (File)
Jan 15 2024, 11:39 PM
Unknown Object (File)
Jan 12 2024, 5:50 PM
Unknown Object (File)
Jan 8 2024, 5:41 PM
Unknown Object (File)
Jan 4 2024, 5:19 PM
Unknown Object (File)
Dec 31 2023, 7:36 PM
Subscribers
None

Details

Summary

Ref T13098. I eventually got unit tests sort-of-almost running and they caught these two issues. Since the tests don't get very far with these classtree problems, just fix them up now so when arc unit actually runs later on it can meaningfully run tests.

Test Plan

Ran arc unit, after other changes let it run, and saw fewer "class doesn't implement every abstract method" issues.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 20900
Build 28415: Run Core Tests

Event Timeline

epriestley created this revision.
This revision is now accepted and ready to land.Sep 26 2018, 6:04 PM
This revision was automatically updated to reflect the committed changes.