Page MenuHomePhabricator

[Wilds] Fix some minor classtree issues identified by unit tests
ClosedPublic

Authored by epriestley on Sep 25 2018, 10:35 PM.

Details

Summary

Ref T13098. I eventually got unit tests sort-of-almost running and they caught these two issues. Since the tests don't get very far with these classtree problems, just fix them up now so when arc unit actually runs later on it can meaningfully run tests.

Test Plan

Ran arc unit, after other changes let it run, and saw fewer "class doesn't implement every abstract method" issues.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley requested review of this revision.Sep 25 2018, 10:35 PM
epriestley created this revision.
amckinley accepted this revision.Sep 26 2018, 6:04 PM
This revision is now accepted and ready to land.Sep 26 2018, 6:04 PM
This revision was automatically updated to reflect the committed changes.