Page MenuHomePhabricator

[Wilds] Fix some minor classtree issues identified by unit tests
ClosedPublic

Authored by epriestley on Sep 25 2018, 10:35 PM.
Tags
None
Referenced Files
F14020956: D19708.diff
Wed, Nov 6, 3:52 AM
F13998198: D19708.diff
Thu, Oct 24, 8:04 AM
F13974579: D19708.id47086.diff
Fri, Oct 18, 6:16 AM
F13965152: D19708.id47103.diff
Wed, Oct 16, 12:15 AM
F13959824: D19708.id.diff
Mon, Oct 14, 8:52 PM
Unknown Object (File)
Oct 9 2024, 10:16 AM
Unknown Object (File)
Sep 21 2024, 9:12 PM
Unknown Object (File)
Sep 6 2024, 4:04 AM
Subscribers
None

Details

Summary

Ref T13098. I eventually got unit tests sort-of-almost running and they caught these two issues. Since the tests don't get very far with these classtree problems, just fix them up now so when arc unit actually runs later on it can meaningfully run tests.

Test Plan

Ran arc unit, after other changes let it run, and saw fewer "class doesn't implement every abstract method" issues.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision is now accepted and ready to land.Sep 26 2018, 6:04 PM
This revision was automatically updated to reflect the committed changes.