Page MenuHomePhabricator

[Wilds] Implement a Filesystem::concatenatePaths(...) method
ClosedPublic

Authored by epriestley on Sep 18 2018, 8:01 PM.
Tags
None
Referenced Files
F18769091: D19691.id.diff
Wed, Oct 8, 6:28 AM
F18750692: D19691.diff
Sat, Oct 4, 8:42 AM
F18739980: D19691.diff
Wed, Oct 1, 11:46 PM
F18458548: D19691.id.diff
Sep 1 2025, 2:50 PM
F18447931: D19691.diff
Aug 31 2025, 11:06 PM
F18095101: D19691.id.diff
Aug 7 2025, 10:31 PM
F17937865: D19691.id.diff
Jul 31 2025, 1:40 AM
Unknown Object (File)
Jun 18 2025, 1:51 PM
Subscribers
None

Details

Summary

Ref T13098. This is mostly for getting sensible results under Windows, hopefully instead of weird mixed paths with both / and \, at least in more cases.

You can pass in several components like array('/path/to/something/', '/thing.c') and they'll be concatenated with exactly one correct separator.

Test Plan

Used this in the new WorkingCopy stuff, which doesn't run yet. 💁

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision is now accepted and ready to land.Sep 19 2018, 11:18 PM
epriestley added inline comments.
src/filesystem/Filesystem.php
1057

("Hilariously", this is missing a third parameter and doesn't work at all, but got fixed later.)

This revision was automatically updated to reflect the committed changes.