Page MenuHomePhabricator
Differential D19649

Layout Phriction actions without floats, to avoid conflicts with floating content
ClosedPublic
Actions

Authored by epriestley on Sep 7 2018, 7:21 PM.
Tags
None
Referenced Files
F15544882: D19649.id.diff
Sat, Apr 26, 7:37 AM
F15540947: D19649.diff
Fri, Apr 25, 9:51 AM
F15516458: D19649.id46962.diff
Fri, Apr 18, 7:04 PM
F15466036: D19649.id46961.diff
Thu, Apr 3, 12:57 AM
F15456051: D19649.id46962.diff
Sun, Mar 30, 6:39 AM
F15435279: D19649.id.diff
Mar 25 2025, 7:40 AM
F15431054: D19649.diff
Mar 24 2025, 10:15 AM
Unknown Object (File)
Feb 25 2025, 2:28 PM
View All Files
Subscribers
• GoogleLegacy

Details

Reviewers
amckinley
Maniphest Tasks
T13195: 2018 Week 36 Bonus Content
Commits
rPa8841d9cffa9: (stable) Layout Phriction actions without floats, to avoid conflicts with…
rP6dc721009d9e: Layout Phriction actions without floats, to avoid conflicts with floating…
Summary

Ref T13195. If a Phriction page begins with a code block, the clear: both; currently makes it clear the action list.

Instead, use table-cell layout on desktops.

Test Plan

Viewed a Phriction page with an initial code block on desktop/tablet/mobile/printable layouts. Now got more sensible layouts in all cases.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
view/
phui/
18 lines
webroot/
rsrc/
css/
phui/
16 lines

Diff 46962

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIDocumentView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-document-pro.css

Loading...
Phabricator · Built by Phacility