Page MenuHomePhabricator
Differential D19649

Layout Phriction actions without floats, to avoid conflicts with floating content
ClosedPublic
Actions

Authored by epriestley on Sep 7 2018, 7:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 5:03 AM
Unknown Object (File)
Mon, Jan 27, 12:21 PM
Unknown Object (File)
Sat, Jan 25, 2:14 AM
Unknown Object (File)
Sat, Jan 25, 2:14 AM
Unknown Object (File)
Sat, Jan 25, 2:14 AM
Unknown Object (File)
Sat, Jan 25, 2:14 AM
Unknown Object (File)
Thu, Jan 23, 5:10 AM
Unknown Object (File)
Fri, Jan 17, 10:42 PM
View All Files
Subscribers
• GoogleLegacy

Details

Reviewers
amckinley
Maniphest Tasks
T13195: 2018 Week 36 Bonus Content
Commits
rPa8841d9cffa9: (stable) Layout Phriction actions without floats, to avoid conflicts with…
rP6dc721009d9e: Layout Phriction actions without floats, to avoid conflicts with floating…
Summary

Ref T13195. If a Phriction page begins with a code block, the clear: both; currently makes it clear the action list.

Instead, use table-cell layout on desktops.

Test Plan

Viewed a Phriction page with an initial code block on desktop/tablet/mobile/printable layouts. Now got more sensible layouts in all cases.

Diff Detail

Repository
rP Phabricator
Branch
wiki1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20768
Build 28239: Run Core Tests
Build 28238: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
view/
phui/
18 lines
webroot/
rsrc/
css/
phui/
16 lines

Diff 46961

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIDocumentView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-document-pro.css

Loading...
Phabricator · Built by Phacility