Differential D19644

Make a language improvement ("inlines" -> "inline comments")
ClosedPublic
Actions

Authored by epriestley on Sep 6 2018, 5:56 PM.

Tags

None

Referenced Files

	F19043999: D19644.id.diff
	Thu, Nov 27, 1:26 AM

	F18905959: D19644.id46948.diff
	Sat, Nov 8, 4:20 PM

	F18833961: D19644.id46950.diff
	Oct 26 2025, 6:48 AM

	F18833960: D19644.id46948.diff
	Oct 26 2025, 6:48 AM

	F18833959: D19644.id.diff
	Oct 26 2025, 6:48 AM

	F18832441: D19644.diff
	Oct 25 2025, 9:54 PM

	F18807169: D19644.id46948.diff
	Oct 18 2025, 11:34 PM

	F18806825: D19644.id46948.diff
	Oct 18 2025, 9:43 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPe8e5dc0f5690: Make a language improvement ("inlines" -> "inline comments")

Summary

See D19632. Agreed that this is more clear.

Test Plan

Read carefully.

Diff Detail

Repository

rP Phabricator

Branch

inlines1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20756
Build 28222: Run Core Tests
Build 28221: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 6 2018, 5:56 PM

Harbormaster completed remote builds in B20756: Diff 46948.Sep 6 2018, 5:57 PM

epriestley requested review of this revision.Sep 6 2018, 5:57 PM

amckinley accepted this revision.Sep 6 2018, 6:39 PM

This revision is now accepted and ready to land.Sep 6 2018, 6:39 PM

Closed by commit rPe8e5dc0f5690: Make a language improvement ("inlines" -> "inline comments") (authored by epriestley). · Explain WhySep 6 2018, 6:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

2 lines

Diff 46948

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Make a language improvement ("inlines" -> "inline comments")ClosedPublicActions