Differential D19636

When applying repository operations via Drydock, provide more context on OperationType
ClosedPublic
Actions

Authored by epriestley on Sep 4 2018, 7:50 PM.

Tags

None

Referenced Files

	F15465876: D19636.id46941.diff
	Thu, Apr 3, 12:00 AM

	F15442629: D19636.diff
	Wed, Mar 26, 11:51 PM

	F15437164: D19636.id.diff
	Tue, Mar 25, 6:00 PM

	F15430509: D19636.diff
	Mon, Mar 24, 7:59 AM

	F15388949: D19636.diff
	Sat, Mar 15, 4:43 AM

	F15381568: D19636.id46941.diff
	Fri, Mar 14, 8:25 AM

	Unknown Object (File)
	Feb 22 2025, 2:34 AM

	Unknown Object (File)
	Feb 22 2025, 2:33 AM

Subscribers

Restricted Owners Package

Details

Reviewers

Maniphest Tasks

T13195: 2018 Week 36 Bonus Content

Commits

rPe6ee5ee9a104: When applying repository operations via Drydock, provide more context on…

Summary

Ref T13195. See PHI845. For custom OperationTypes, provide access to the Interface and Operation via getters. This is just for convenience, since passing these around everywhere can be a bit of a pain if you have a deep-ish stack of things or love using callbacks or whatever.

Test Plan

Landed a revision via upstream Drydock operations.

Diff Detail

Repository

Branch

drydock1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20736
Build 28191: Run Core Tests
Build 28190: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 4 2018, 7:50 PM

Owners added a subscriber: Restricted Owners Package.Sep 4 2018, 7:50 PM

Harbormaster completed remote builds in B20736: Diff 46928.Sep 4 2018, 7:51 PM

epriestley requested review of this revision.Sep 4 2018, 7:51 PM

amckinley accepted this revision.Sep 5 2018, 10:35 PM

This revision is now accepted and ready to land.Sep 5 2018, 10:35 PM

Closed by commit rPe6ee5ee9a104: When applying repository operations via Drydock, provide more context on… (authored by epriestley). · Explain WhySep 6 2018, 3:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

operation/

DrydockRepositoryOperationType.php

23 lines

query/

DrydockRepositoryOperationQuery.php

7 lines

storage/

DrydockRepositoryOperation.php

6 lines

worker/

DrydockRepositoryOperationUpdateWorker.php

5 lines

Diff 46928

src/applications/drydock/operation/DrydockRepositoryOperationType.php

Loading...

src/applications/drydock/query/DrydockRepositoryOperationQuery.php

Loading...

src/applications/drydock/storage/DrydockRepositoryOperation.php

Loading...

src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php

Loading...