Page MenuHomePhabricator

Add "Revision test plan" as a Herald field; remove test plan from the "Revision summary" field
ClosedPublic

Authored by epriestley on Aug 29 2018, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 3:34 PM
Unknown Object (File)
Tue, Jan 21, 9:26 AM
Unknown Object (File)
Thu, Jan 2, 11:44 PM
Unknown Object (File)
Tue, Dec 24, 3:52 AM
Unknown Object (File)
Dec 2 2024, 3:15 AM
Unknown Object (File)
Nov 28 2024, 8:45 PM
Unknown Object (File)
Nov 26 2024, 2:28 PM
Unknown Object (File)
Nov 19 2024, 8:57 AM
Subscribers
None

Details

Summary

See PHI844. Ref T13189.

Add "Revision test plan" as an available field for Herald. This is a little niche -- and a little odd because it sticks around even if you fully disable test plans -- but probably broadly reasonable.

The existing "Revision summary" field counterintuitively included the test plan. Separate this out since it's now a separate field and the behavior was weird historic nonsense. I'll note this in the changelog.

Test Plan

Wrote a rule using both fields, verified they generated the expected values.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2018, 9:17 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.