Page MenuHomePhabricator

Add "Revision test plan" as a Herald field; remove test plan from the "Revision summary" field
ClosedPublic

Authored by epriestley on Aug 29 2018, 9:15 PM.
Tags
None
Referenced Files
F18181757: D19623.diff
Sat, Aug 16, 8:48 AM
F17885811: D19623.id46907.diff
Jul 29 2025, 12:33 AM
F17855204: D19623.id46908.diff
Jul 27 2025, 4:01 PM
F17847744: D19623.diff
Jul 27 2025, 6:29 AM
Unknown Object (File)
May 19 2025, 10:04 AM
Unknown Object (File)
Apr 25 2025, 5:05 PM
Unknown Object (File)
Apr 24 2025, 8:39 AM
Unknown Object (File)
Apr 11 2025, 12:39 PM
Subscribers
None

Details

Summary

See PHI844. Ref T13189.

Add "Revision test plan" as an available field for Herald. This is a little niche -- and a little odd because it sticks around even if you fully disable test plans -- but probably broadly reasonable.

The existing "Revision summary" field counterintuitively included the test plan. Separate this out since it's now a separate field and the behavior was weird historic nonsense. I'll note this in the changelog.

Test Plan

Wrote a rule using both fields, verified they generated the expected values.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20712
Build 28154: Run Core Tests
Build 28153: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2018, 9:17 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.