Page MenuHomePhabricator

Fix Filesytem::walkToRoot() on Windows with default ("/") root
ClosedPublic

Authored by epriestley on Aug 15 2018, 5:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 31 2023, 4:40 PM
Unknown Object (File)
Dec 30 2023, 5:47 PM
Unknown Object (File)
Dec 27 2023, 12:49 PM
Unknown Object (File)
Dec 27 2023, 12:49 PM
Unknown Object (File)
Dec 27 2023, 12:49 PM
Unknown Object (File)
Dec 26 2023, 8:24 PM
Unknown Object (File)
Dec 24 2023, 6:27 AM
Unknown Object (File)
Dec 22 2023, 12:13 AM
Subscribers
None

Details

Summary

Fixes T9459. See PHI817. An install is reporting that arc upgrade fails on Windows, failing to recognize that arcanist/ is a Git working copy.

This appears to reproduce for me, and boil down to FileList->contains() testing if / contains C:\Application Data32\Roaming\My Documents\Users\epriestley\devtools\arcanist. It (literally) does not, but our intent is that it should.

Instead of defaulting the root to /, treat it somewhat more specially so Filesystem::walkToRoot(X) on Windows always walks all the way up.

Test Plan

This is slightly shaky since my Windows "development environment" is a mess, but I was able to run arc upgrade with this patch applied and make it through working copy recognition. I'll re-test after landing.

Diff Detail

Repository
rPHU libphutil
Branch
walk1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20623
Build 28027: Run Core Tests
Build 28026: arc lint + arc unit