Differential D19578

Remove some array typehints for passing around
ClosedPublic
Actions

Authored by amckinley on Aug 13 2018, 10:38 PM.

Tags

None

Referenced Files

	F19102924: D19578.diff
	Dec 5 2025, 8:10 AM

	F18772019: D19578.id46808.diff
	Oct 8 2025, 11:39 PM

	F18767795: D19578.diff
	Oct 8 2025, 12:22 AM

	F18696752: D19578.diff
	Sep 27 2025, 8:21 AM

	F18509739: D19578.id.diff
	Sep 5 2025, 3:34 AM

	F18503131: D19578.diff
	Sep 4 2025, 10:52 PM

	F17711950: D19578.diff
	Jul 17 2025, 9:20 AM

	F17644505: D19578.id46810.diff
	Jul 11 2025, 10:38 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPcc1def6ceaab: Remove some array typehints for passing around

Summary

See discussion at https://secure.phabricator.com/D19492#241996

Test Plan

Refreshed a few Diffusion tabs; nothing broke.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

amckinley created this revision.Aug 13 2018, 10:38 PM

Harbormaster completed remote builds in B20608: Diff 46808.Aug 13 2018, 10:39 PM

amckinley requested review of this revision.Aug 13 2018, 10:39 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 13 2018, 10:39 PM

epriestley accepted this revision.Aug 13 2018, 11:02 PM

This revision is now accepted and ready to land.Aug 13 2018, 11:02 PM

Closed by commit rPcc1def6ceaab: Remove some array typehints for passing around (authored by amckinley). · Explain WhyAug 13 2018, 11:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepositoryCommit.php

6 lines

subscriptions/

view/

SubscriptionListDialogBuilder.php

2 lines

Diff 46810

View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php