Page MenuHomePhabricator

Remove 750ms timeout on owners path validation
ClosedPublic

Authored by epriestley on Aug 13 2018, 6:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 4:00 AM
Unknown Object (File)
Sat, Jan 25, 1:54 AM
Unknown Object (File)
Sat, Jan 25, 1:54 AM
Unknown Object (File)
Sat, Jan 25, 1:54 AM
Unknown Object (File)
Thu, Jan 16, 8:21 PM
Unknown Object (File)
Sat, Jan 11, 1:50 PM
Unknown Object (File)
Dec 30 2024, 11:46 AM
Unknown Object (File)
Dec 30 2024, 11:46 AM
Subscribers
None

Details

Summary

Ref T13164. See PHI748. Path validation has a 750ms timeout which blames to rP5038ab850c, in 2011.

Production path validation is sometimes taking more than 750ms, particularly on the initial page load where we may validate many paths simultaneously.

I have no idea why we have this timeout, and it isn't consistent with how we perform other AJAX requests. Just remove it.

Test Plan
  • Reproduced issue in production, saw all validation calls failing at 750ms. Actual underlying calls succeed, they just take more than 750ms to resolve.
  • Loaded path validator locally, got green checkmark.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 13 2018, 7:48 PM
This revision was automatically updated to reflect the committed changes.