Page MenuHomePhabricator

In "bin/ssh-auth", cache a structure instead of a flat file because paths may change at runtime
ClosedPublic

Authored by epriestley on Aug 8 2018, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 31, 4:24 PM
Unknown Object (File)
Thu, Jan 26, 2:46 AM
Unknown Object (File)
Thu, Jan 19, 7:31 PM
Unknown Object (File)
Tue, Jan 10, 6:57 AM
Unknown Object (File)
Jan 3 2023, 1:24 PM
Unknown Object (File)
Dec 28 2022, 6:48 PM
Unknown Object (File)
Dec 27 2022, 3:51 AM
Unknown Object (File)
Dec 19 2022, 5:50 PM
Subscribers
None

Details

Summary

Fixes T12397. Ref T13164. See PHI801.

Several installs have hit various use cases where the path on disk where Phabricator lives changes at runtime. Currently, bin/ssh-auth caches a flat file which includes the path to bin/ssh-exec, so this may fall out of date if phabricator/ moves.

These use cases have varying strengths of legitimacy, but "we're migrating to a new set of hosts and the pool is half old machines and half new machines" seems reasonably compelling and not a problem entirely of one's own making.

Test Plan
  • Compared output on master to output after change, found them byte-for-byte identical.
  • Moved phabricator/ to phabricator2/, ran bin/ssh-auth, got updated output.
  • Added a new SSH key, saw it appear in the output.
  • Grepped for AUTHFILE_CACHEKEY (no hits).
  • Dropped the cache, verified that the file regenerates cleanly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable