Differential D19564
Improve "--trace" behavior when output includes binary queries Authored by epriestley on Aug 3 2018, 9:49 PM. Tags None Referenced Files
Subscribers None
Details
Ref T13164. See PHI766. If you bin/harbormaster rebuild-log ... --force --trace, you can get a trace with a bunch of binary gzip data in it. This tends to make your terminal beep a lot and sometimes turn into funny colors or symbols. Instead, replace runs of binary data with the text "<...binary data...>". Also, collapse multiple consecutive whitespace characters into a single whitespace character. Broadly, both changes make these traces easier to read. Ran bin/harbormaster rebuild-log ... --force --trace on a 20MB log of reasonably normal data, no longer got beeped at fifty times.
Diff Detail
Event Timeline
Comment Actions Yep -- or that's what I tried to write, at least. Although note the final *, so this also matches a single byte in 0-31,127-255 with nothing else. I believe we only need /u when we want certain somewhat-unusual stuff to work like having \s or \B match particular multilingual space/boundary characters or make . match multi-byte characters as a single thing. | ||||||||||||||||||||||||||||||||||||