Differential D19561

Consolidate redundant "should should" from some linter help strings in Arcanist
ClosedPublic
Actions

Authored by epriestley on Aug 3 2018, 7:59 PM.

Tags

None

Referenced Files

	F15526325: D19561.id.diff
	Mon, Apr 21, 8:36 PM

	F15511543: D19561.id46765.diff
	Thu, Apr 17, 2:52 AM

	F15507858: D19561.id.diff
	Tue, Apr 15, 11:31 PM

	F15505489: D19561.id.diff
	Tue, Apr 15, 3:23 AM

	F15503848: D19561.diff
	Mon, Apr 14, 1:38 PM

	F15487489: D19561.diff
	Thu, Apr 10, 2:34 PM

	F15471884: D19561.diff
	Sat, Apr 5, 8:53 AM

	F15462662: D19561.id.diff
	Tue, Apr 1, 4:34 PM

View All Files

Subscribers

None

Tokens

"Pterodactyl" token, awarded by epriestley.

Details

Reviewers

amckinley

Commits

rARC9dfa68d739ee: (stable) Promote 2018 Week 31
rARCd9a4293ae734: Consolidate redundant "should should" from some linter help strings in Arcanist

Summary

See https://phabricator.wikimedia.org/T201138.

Test Plan

Read carefully.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 3 2018, 7:59 PM

Harbormaster completed remote builds in B20564: Diff 46765.Aug 3 2018, 7:59 PM

epriestley requested review of this revision.Aug 3 2018, 7:59 PM

This revision is now accepted and ready to land.Aug 3 2018, 8:35 PM

epriestley awarded a token.Aug 3 2018, 8:40 PM

Closed by commit rARCd9a4293ae734: Consolidate redundant "should should" from some linter help strings in Arcanist (authored by epriestley). · Explain WhyAug 3 2018, 9:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistDeprecationXHPASTLinterRule.php

2 lines

ArcanistUnsafeDynamicStringXHPASTLinterRule.php

6 lines

Diff 46771

View Options

src/lint/linter/xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php