Differential D19530

Give Config the "✨" (SPARKLE LIKE NEW) emoji instead of "☺" (STUPID LOOKING FACE)
ClosedPublic
Actions

Authored by epriestley on Jul 20 2018, 10:42 PM.

Details

Reviewers

Maniphest Tasks

T13171: Config has some kind of goofy looking face emoji as a Unicode glyph, which renders as particular nonsense in recent versions of macOS

Commits

rPdee453c94d44: Give Config the "✨" (SPARKLE LIKE NEW) emoji instead of "☺" (STUPID LOOKING…

Summary

Fixes T13171. Open to suggestions but that face looks real, real dumb on High Sierra.

Test Plan

Visited Config, saw a serious professional emoji in the page title.

Diff Detail

Repository

rP Phabricator

Branch

configmoji

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20490
Build 27830: Run Core Tests
Build 27829: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 20 2018, 10:42 PM

Harbormaster completed remote builds in B20490: Diff 46692.Jul 20 2018, 10:43 PM

epriestley requested review of this revision.Jul 20 2018, 10:43 PM

amckinley accepted this revision.Jul 23 2018, 7:00 PM

This revision is now accepted and ready to land.Jul 23 2018, 7:00 PM

Closed by commit rPdee453c94d44: Give Config the "✨" (SPARKLE LIKE NEW) emoji instead of "☺" (STUPID LOOKING… (authored by epriestley). · Explain WhyJul 23 2018, 7:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

application/

PhabricatorConfigApplication.php

2 lines

Diff 46692

View Options

src/applications/config/application/PhabricatorConfigApplication.php

Give Config the "✨" (SPARKLE LIKE NEW) emoji instead of "☺" (STUPID LOOKING FACE)ClosedPublicActions