Page MenuHomePhabricator

Add test plan to differential.revision.search
ClosedPublic

Authored by amckinley on Jul 20 2018, 3:48 AM.
Tags
None
Referenced Files
F14076251: D19518.id46672.diff
Thu, Nov 21, 4:26 PM
Unknown Object (File)
Thu, Nov 14, 4:50 PM
Unknown Object (File)
Wed, Nov 13, 1:10 AM
Unknown Object (File)
Oct 9 2024, 9:42 AM
Unknown Object (File)
Sep 9 2024, 2:05 PM
Unknown Object (File)
Sep 6 2024, 3:34 AM
Unknown Object (File)
Sep 5 2024, 9:17 AM
Unknown Object (File)
Aug 30 2024, 10:10 AM
Subscribers

Details

Summary

Ref T13151. Ref PHI622.

Test Plan

Loaded a revision in the Conduit UI; observed presence of testPlan field.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think this is a good practical fix to PHI622, particularly considering that summary is already present.

Two hypothetical future concerns that I think aren't actually worth dealing with today:

  • In theory, this field should enable/disable itself if you enable/disable the "Test Plan" custom field, and the "Test Plan" custom field should provide the value to Conduit without needing any code here. I looked at this briefly but couldn't find a straightforward pathway, I believe. The Differential custom field code has generally been improving through adjacent changes over time so I'm reasonably confident we'll get somewhere sensible eventually.
  • Elsewhere, at least some remarkup-valued fields are futureproofed by returning a dictionary value like {"raw": "zebra"} instead of just a string ("zebra"). One example is the ManiphestTask description field on maniphest.search. This dictionary could support options like "render all remarkup to text/html in the return value", "support storing non-Remarkup values [e.g. commit messages written in Markdown]", and so on. It's not clear to me that this will ever actually be valuable, but we'd be in a bit of trouble today if we decided we do want to accommodate it. But, here, we already have to work with 'summary' so I think we're not in a materially worse position by not adopting this vague possible futureproofing.
This revision is now accepted and ready to land.Jul 20 2018, 3:35 PM
This revision was automatically updated to reflect the committed changes.