Page MenuHomePhabricator
Differential D19514

Update parent/child revision timeline messages to use modern language ("parent revision")
ClosedPublic
Actions

Authored by epriestley on Jul 9 2018, 9:36 PM.
Tags
None
Referenced Files
F13089303: D19514.diff
Thu, Apr 25, 1:44 AM
Unknown Object (File)
Fri, Apr 19, 7:49 PM
Unknown Object (File)
Tue, Apr 2, 9:04 AM
Unknown Object (File)
Mar 21 2024, 3:21 AM
Unknown Object (File)
Mar 12 2024, 8:34 PM
Unknown Object (File)
Feb 21 2024, 10:35 PM
Unknown Object (File)
Jan 31 2024, 2:22 AM
Unknown Object (File)
Jan 25 2024, 4:44 AM
View All 92 Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13151: Plans: 2018 Week 23 - Week 30 Bonus Content
Commits
rP185c28f307e4: Update parent/child revision timeline messages to use modern language ("parent…
Summary

See PHI746. See also T11833, perhaps. Ref T13151.

Long ago, parent revisions were called "dependent revisions". This was changed to "parent revisions" in the action UI to improve clarity, but not changed in the timeline stories.

Update the timeline stories to use the same language the actions in the UI use.

Test Plan

Screen Shot 2018-07-09 at 2.26.11 PM.png (387×610 px, 65 KB)

Screen Shot 2018-07-09 at 2.26.08 PM.png (437×631 px, 72 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 9 2018, 9:36 PM
Harbormaster completed remote builds in B20469: Diff 46665.Jul 9 2018, 9:37 PM
epriestley requested review of this revision.Jul 9 2018, 9:37 PM
epriestley added inline comments.Jul 9 2018, 9:40 PM
src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
663–670

Long ago, this edit (adding and removing child revisions in one action) wasn't possible, which is why there was no string for it. When the UI got updated we got a full-power "Edit Child Revisions" and this action is now an actual action.

amckinley accepted this revision.Jul 10 2018, 4:00 PM
This revision is now accepted and ready to land.Jul 10 2018, 4:00 PM
Closed by commit rP185c28f307e4: Update parent/child revision timeline messages to use modern language ("parent… (authored by epriestley). · Explain WhyJul 13 2018, 4:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
edge/
12 lines
12 lines
infrastructure/
internationalization/
translation/
66 lines

Diff 46666

View Options

src/applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php

Loading...
View Options

src/applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility