Page MenuHomePhabricator
Differential D19507

Fix querying for transactions over "transaction.search" when the object does not support comments
ClosedPublic
Actions

Authored by epriestley on Jun 25 2018, 1:01 PM.
Tags
None
Referenced Files
F15470380: D19507.id46647.diff
Fri, Apr 4, 9:43 PM
F15462987: D19507.id.diff
Tue, Apr 1, 7:32 PM
F15462782: D19507.diff
Tue, Apr 1, 5:42 PM
F15442810: D19507.id46644.diff
Thu, Mar 27, 12:36 AM
F15428605: D19507.id46647.diff
Sun, Mar 23, 9:17 PM
F15412079: D19507.id46647.diff
Wed, Mar 19, 11:11 AM
F15370130: D19507.diff
Wed, Mar 12, 9:10 AM
F15367514: D19507.diff
Tue, Mar 11, 7:01 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13151: Plans: 2018 Week 23 - Week 30 Bonus Content
Commits
rPf94cee862888: Fix querying for transactions over "transaction.search" when the object does…
Summary

See PHI725. Ref T13151. We currently try to load comments unconditionally, but not all objects (like projects) have comments. Only try to load comments if an object actually has comments.

Test Plan

Queried for an object with no comments, like project #masonry, via transaction.search.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
conduit/
25 lines

Diff 46647

View Options

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility