Paths

Table of Contentst

Differential D19507

Fix querying for transactions over "transaction.search" when the object does not support comments
ClosedPublic
Actions

Authored by epriestley on Jun 25 2018, 1:01 PM.

Tags

None

Referenced Files

	F18092855: D19507.id46647.diff
	Thu, Aug 7, 1:35 PM

	F17951474: D19507.id46647.diff
	Fri, Aug 1, 1:23 AM

	F17882227: D19507.id.diff
	Mon, Jul 28, 10:36 PM

	F17847355: D19507.diff
	Jul 27 2025, 6:04 AM

	F17620065: D19507.id46647.diff
	Jul 9 2025, 8:10 PM

	Unknown Object (File)
	Jun 6 2025, 5:28 AM

	Unknown Object (File)
	May 26 2025, 10:41 PM

	Unknown Object (File)
	May 26 2025, 1:15 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13151: Plans: 2018 Week 23 - Week 30 Bonus Content

Commits

rPf94cee862888: Fix querying for transactions over "transaction.search" when the object does…

Summary

See PHI725. Ref T13151. We currently try to load comments unconditionally, but not all objects (like projects) have comments. Only try to load comments if an object actually has comments.

Test Plan

Queried for an object with no comments, like project #masonry, via transaction.search.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 25 2018, 1:01 PM

Harbormaster completed remote builds in B20452: Diff 46644.Jun 25 2018, 1:02 PM

epriestley requested review of this revision.Jun 25 2018, 1:02 PM

amckinley accepted this revision.Jun 25 2018, 4:29 PM

This revision is now accepted and ready to land.Jun 25 2018, 4:29 PM

Closed by commit rPf94cee862888: Fix querying for transactions over "transaction.search" when the object does… (authored by epriestley). · Explain WhyJun 26 2018, 2:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

conduit/

TransactionSearchConduitAPIMethod.php

25 lines

Diff 46647

View Options

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php

Fix querying for transactions over "transaction.search" when the object does not support commentsClosedPublicActions