Page MenuHomePhabricator

Fix querying for transactions over "transaction.search" when the object does not support comments
ClosedPublic

Authored by epriestley on Jun 25 2018, 1:01 PM.

Details

Summary

See PHI725. Ref T13151. We currently try to load comments unconditionally, but not all objects (like projects) have comments. Only try to load comments if an object actually has comments.

Test Plan

Queried for an object with no comments, like project #masonry, via transaction.search.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 25 2018, 1:01 PM
epriestley requested review of this revision.Jun 25 2018, 1:02 PM
amckinley accepted this revision.Jun 25 2018, 4:29 PM
This revision is now accepted and ready to land.Jun 25 2018, 4:29 PM
This revision was automatically updated to reflect the committed changes.