Page MenuHomePhabricator

Fix querying for transactions over "transaction.search" when the object does not support comments
ClosedPublic

Authored by epriestley on Jun 25 2018, 1:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 10:24 AM
Unknown Object (File)
Thu, Dec 12, 7:07 AM
Unknown Object (File)
Mon, Dec 9, 8:26 AM
Unknown Object (File)
Nov 26 2024, 11:18 PM
Unknown Object (File)
Nov 25 2024, 9:07 AM
Unknown Object (File)
Nov 22 2024, 9:24 PM
Unknown Object (File)
Nov 22 2024, 2:02 AM
Unknown Object (File)
Nov 18 2024, 2:19 AM
Subscribers
None

Details

Summary

See PHI725. Ref T13151. We currently try to load comments unconditionally, but not all objects (like projects) have comments. Only try to load comments if an object actually has comments.

Test Plan

Queried for an object with no comments, like project #masonry, via transaction.search.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable