Page MenuHomePhabricator

Allow null identities to be attached to commit objects
ClosedPublic

Authored by amckinley on Jun 18 2018, 10:34 PM.
Tags
None
Referenced Files
F15437373: D19496.diff
Tue, Mar 25, 7:02 PM
Unknown Object (File)
Tue, Feb 25, 10:21 PM
Unknown Object (File)
Feb 9 2025, 6:08 AM
Unknown Object (File)
Feb 9 2025, 6:08 AM
Unknown Object (File)
Feb 9 2025, 6:08 AM
Unknown Object (File)
Feb 9 2025, 6:08 AM
Unknown Object (File)
Jan 31 2025, 6:36 AM
Unknown Object (File)
Jan 25 2025, 1:37 AM
Subscribers

Details

Summary

I landed D19491 a little aggressively, so allow this field to be null until after the migration goes out.

Test Plan

Loaded commits without identity objects; did not get any errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

You can also ClassName $v = null to let null through. PHP is a beautiful wild creature.

This revision is now accepted and ready to land.Jun 19 2018, 7:25 PM

That is, the typehint ClassName $x allows only ClassName objects. The typehint ClassName $x = null allows ClassName objects or null, as an amazing side effect of defaulting the parameter to null.

This revision was automatically updated to reflect the committed changes.