Page MenuHomePhabricator

Allow null identities to be attached to commit objects
ClosedPublic

Authored by amckinley on Jun 18 2018, 10:34 PM.
Tags
None
Referenced Files
F18818811: D19496.id46624.diff
Wed, Oct 22, 2:27 AM
F18780379: D19496.id46628.diff
Sun, Oct 12, 9:20 AM
F18719472: D19496.diff
Mon, Sep 29, 5:14 PM
F18509676: D19496.id.diff
Sep 5 2025, 3:32 AM
F18502943: D19496.diff
Sep 4 2025, 10:45 PM
F18487000: D19496.id46624.diff
Sep 3 2025, 7:09 PM
F18468019: D19496.diff
Sep 2 2025, 2:03 PM
F18464128: D19496.diff
Sep 2 2025, 3:23 AM
Subscribers

Details

Summary

I landed D19491 a little aggressively, so allow this field to be null until after the migration goes out.

Test Plan

Loaded commits without identity objects; did not get any errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

You can also ClassName $v = null to let null through. PHP is a beautiful wild creature.

This revision is now accepted and ready to land.Jun 19 2018, 7:25 PM

That is, the typehint ClassName $x allows only ClassName objects. The typehint ClassName $x = null allows ClassName objects or null, as an amazing side effect of defaulting the parameter to null.

This revision was automatically updated to reflect the committed changes.