Page MenuHomePhabricator

Allow null identities to be attached to commit objects
ClosedPublic

Authored by amckinley on Jun 18 2018, 10:34 PM.
Tags
None
Referenced Files
F19878549: D19496.id46624.diff
Mar 17 2026, 12:35 AM
F19877729: D19496.id46628.diff
Mar 16 2026, 6:10 PM
F19789208: D19496.diff
Feb 25 2026, 5:27 PM
F19575717: D19496.diff
Feb 1 2026, 7:28 AM
F19313559: D19496.id46628.diff
Dec 25 2025, 1:38 AM
F18885672: D19496.diff
Nov 7 2025, 3:35 AM
F18842149: D19496.id46628.diff
Oct 28 2025, 1:35 PM
F18818811: D19496.id46624.diff
Oct 22 2025, 2:27 AM
Subscribers

Details

Summary

I landed D19491 a little aggressively, so allow this field to be null until after the migration goes out.

Test Plan

Loaded commits without identity objects; did not get any errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

You can also ClassName $v = null to let null through. PHP is a beautiful wild creature.

This revision is now accepted and ready to land.Jun 19 2018, 7:25 PM

That is, the typehint ClassName $x allows only ClassName objects. The typehint ClassName $x = null allows ClassName objects or null, as an amazing side effect of defaulting the parameter to null.

This revision was automatically updated to reflect the committed changes.