Page MenuHomePhabricator

Allow null identities to be attached to commit objects
ClosedPublic

Authored by amckinley on Jun 18 2018, 10:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 3, 5:03 AM
Unknown Object (File)
Jun 18 2025, 10:00 AM
Unknown Object (File)
Jun 17 2025, 5:41 PM
Unknown Object (File)
May 2 2025, 12:26 AM
Unknown Object (File)
Apr 28 2025, 6:42 PM
Unknown Object (File)
Apr 17 2025, 11:44 PM
Unknown Object (File)
Mar 31 2025, 7:21 PM
Unknown Object (File)
Mar 31 2025, 4:00 AM
Subscribers

Details

Summary

I landed D19491 a little aggressively, so allow this field to be null until after the migration goes out.

Test Plan

Loaded commits without identity objects; did not get any errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

You can also ClassName $v = null to let null through. PHP is a beautiful wild creature.

This revision is now accepted and ready to land.Jun 19 2018, 7:25 PM

That is, the typehint ClassName $x allows only ClassName objects. The typehint ClassName $x = null allows ClassName objects or null, as an amazing side effect of defaulting the parameter to null.

This revision was automatically updated to reflect the committed changes.