Page MenuHomePhabricator

When database connection exceptions occur, raise them to the setup layer
ClosedPublic

Authored by epriestley on May 17 2018, 1:03 PM.
Tags
None
Referenced Files
F13039253: D19454.diff
Tue, Apr 16, 5:57 AM
Unknown Object (File)
Tue, Apr 2, 5:22 PM
Unknown Object (File)
Sun, Mar 31, 3:46 PM
Unknown Object (File)
Sun, Mar 31, 3:46 PM
Unknown Object (File)
Sun, Mar 31, 3:46 PM
Unknown Object (File)
Sun, Mar 31, 2:32 PM
Unknown Object (File)
Wed, Mar 27, 9:34 PM
Unknown Object (File)
Mar 5 2024, 5:59 PM
Subscribers
None

Details

Summary

Ref T13141. Currently, during first-time setup we don't surface all the details about connection exceptions that we could: the underlying exception is discarded inside cluster connection management.

This isn't a huge issue since the reason for connection problems is usually fairly obvious, but in at least one case (see T13141) we hit a less-than-obvious exception.

Instead, store the original exception and propagate the message up the stack so users have more information about the problem.

Test Plan
  • Configured an intentionally bad MySQL username.
  • Restarted Apache and loaded Phabricator.
  • Got a more helpful exception with a specific authentication error message.

Screen Shot 2018-05-17 at 5.56.31 AM.png (968×1 px, 138 KB)

Diff Detail

Repository
rP Phabricator
Branch
ref1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20343
Build 27628: Run Core Tests
Build 27627: arc lint + arc unit