Page MenuHomePhabricator

When database connection exceptions occur, raise them to the setup layer
ClosedPublic

Authored by epriestley on May 17 2018, 1:03 PM.
Tags
None
Referenced Files
F19670434: D19454.id46536.diff
Sat, Feb 7, 10:56 PM
F19670426: D19454.id46536.diff
Sat, Feb 7, 10:54 PM
F19668770: D19454.diff
Sat, Feb 7, 7:50 PM
F19661389: D19454.id46536.diff
Feb 7 2026, 6:41 AM
F19661386: D19454.id46536.diff
Feb 7 2026, 6:41 AM
F19585710: D19454.id46536.diff
Feb 2 2026, 4:23 AM
F19561329: D19454.id.diff
Jan 31 2026, 10:06 AM
F19533430: D19454.diff
Jan 20 2026, 5:33 PM
Subscribers
None

Details

Summary

Ref T13141. Currently, during first-time setup we don't surface all the details about connection exceptions that we could: the underlying exception is discarded inside cluster connection management.

This isn't a huge issue since the reason for connection problems is usually fairly obvious, but in at least one case (see T13141) we hit a less-than-obvious exception.

Instead, store the original exception and propagate the message up the stack so users have more information about the problem.

Test Plan
  • Configured an intentionally bad MySQL username.
  • Restarted Apache and loaded Phabricator.
  • Got a more helpful exception with a specific authentication error message.

Screen Shot 2018-05-17 at 5.56.31 AM.png (968×1 px, 138 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable