Page MenuHomePhabricator

Parse unusual Subversion protocol frames which contain extra whitespace
ClosedPublic

Authored by epriestley on May 15 2018, 10:58 PM.
Tags
None
Referenced Files
F13342208: D19451.diff
Thu, Jun 20, 10:59 AM
F13333591: D19451.diff
Tue, Jun 18, 8:06 AM
F13330903: D19451.diff
Mon, Jun 17, 5:16 AM
F13316783: D19451.diff
Thu, Jun 13, 8:35 AM
F13307684: D19451.diff
Sun, Jun 9, 8:52 PM
F13283128: D19451.diff
Sun, Jun 2, 12:51 PM
F13269822: D19451.diff
Wed, May 29, 7:47 AM
F13268638: D19451.diff
Wed, May 29, 5:14 AM
Subscribers
None

Details

Summary

Fixes T13140. See PHI660.

Recent versions of Subversion can send a (get-file true false false ) protocol frame with extra space between "false" and "false". This is allowed by the protocol spec, but never normally happens, and we do not parse it correctly.

Instead, parse it correctly.

Test Plan
  • Added unit tests.
  • Ran svn proplist svn+ssh://.../diffusion/X/file.c under SVN 1.10 before and after the change.
    • Before: indefinite hang.
    • After: completed in finite time.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable