Page MenuHomePhabricator

Parse unusual Subversion protocol frames which contain extra whitespace
ClosedPublic

Authored by epriestley on May 15 2018, 10:58 PM.
Tags
None
Referenced Files
F13215484: D19451.id46532.diff
Fri, May 17, 5:42 PM
F13213665: D19451.diff
Fri, May 17, 7:59 AM
F13176833: D19451.id46528.diff
Wed, May 8, 5:38 PM
Unknown Object (File)
Tue, May 7, 7:46 AM
Unknown Object (File)
Fri, May 3, 7:24 AM
Unknown Object (File)
Thu, Apr 25, 1:31 AM
Unknown Object (File)
Fri, Apr 19, 7:44 PM
Unknown Object (File)
Apr 11 2024, 9:04 AM
Subscribers
None

Details

Summary

Fixes T13140. See PHI660.

Recent versions of Subversion can send a (get-file true false false ) protocol frame with extra space between "false" and "false". This is allowed by the protocol spec, but never normally happens, and we do not parse it correctly.

Instead, parse it correctly.

Test Plan
  • Added unit tests.
  • Ran svn proplist svn+ssh://.../diffusion/X/file.c under SVN 1.10 before and after the change.
    • Before: indefinite hang.
    • After: completed in finite time.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable