Page MenuHomePhabricator
Differential D19432

Don't render the Maniphest edit form bottom-of-page preview panel if "Description" is locked or hidden
ClosedPublic
Actions

Authored by epriestley on May 7 2018, 8:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 10:27 AM
Unknown Object (File)
Wed, Nov 20, 8:59 AM
Unknown Object (File)
Wed, Nov 20, 8:38 AM
Unknown Object (File)
Tue, Nov 19, 9:09 PM
Unknown Object (File)
Tue, Nov 19, 5:49 AM
Unknown Object (File)
Sat, Nov 16, 8:45 AM
Unknown Object (File)
Mon, Nov 11, 8:04 PM
Unknown Object (File)
Fri, Nov 8, 4:58 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPfddb506e987f: Don't render the Maniphest edit form bottom-of-page preview panel if…
Summary

See https://discourse.phabricator-community.org/t/hidden-description-field-in-maniphest-task-breaks-form/1432.

If you hide the "Description" field in Maniphest, we still try to render a remarkup preview for it. This causes a JS error and a nonfunctional element on the page.

Instead, hide the preview panel if the field has been locked or hidden.

Test Plan
  • Hid the field, loaded the form, no more preview panel / JS error.
  • Used a normal form with the field visible, saw a normal preview.

Diff Detail

Repository
rP Phabricator
Branch
rpreview1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20290
Build 27545: Run Core Tests
Build 27544: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editfield/
8 lines

Diff 46479

View Options

src/applications/transactions/editfield/PhabricatorEditField.php

Loading...
Phabricator · Built by Phacility