Page MenuHomePhabricator

Don't render the Maniphest edit form bottom-of-page preview panel if "Description" is locked or hidden
ClosedPublic

Authored by epriestley on May 7 2018, 8:56 PM.
Tags
None
Referenced Files
F15565784: D19432.id46479.diff
Thu, May 1, 9:10 AM
F15523138: D19432.id46483.diff
Sun, Apr 20, 11:23 PM
F15517883: D19432.id.diff
Sat, Apr 19, 9:15 AM
F15514675: D19432.diff
Fri, Apr 18, 4:27 AM
F15494311: D19432.id46479.diff
Sat, Apr 12, 11:13 PM
F15491944: D19432.id46479.diff
Sat, Apr 12, 9:15 AM
F15469946: D19432.id46483.diff
Apr 4 2025, 6:23 PM
F15463458: D19432.id46479.diff
Apr 1 2025, 11:41 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/hidden-description-field-in-maniphest-task-breaks-form/1432.

If you hide the "Description" field in Maniphest, we still try to render a remarkup preview for it. This causes a JS error and a nonfunctional element on the page.

Instead, hide the preview panel if the field has been locked or hidden.

Test Plan
  • Hid the field, loaded the form, no more preview panel / JS error.
  • Used a normal form with the field visible, saw a normal preview.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable