Differential D19432

Don't render the Maniphest edit form bottom-of-page preview panel if "Description" is locked or hidden
ClosedPublic
Actions

Authored by epriestley on May 7 2018, 8:56 PM.

Details

Reviewers

amckinley

Commits

rPfddb506e987f: Don't render the Maniphest edit form bottom-of-page preview panel if…

Summary

See https://discourse.phabricator-community.org/t/hidden-description-field-in-maniphest-task-breaks-form/1432.

If you hide the "Description" field in Maniphest, we still try to render a remarkup preview for it. This causes a JS error and a nonfunctional element on the page.

Instead, hide the preview panel if the field has been locked or hidden.

Test Plan

Hid the field, loaded the form, no more preview panel / JS error.
Used a normal form with the field visible, saw a normal preview.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 7 2018, 8:56 PM

Harbormaster completed remote builds in B20290: Diff 46479.May 7 2018, 8:57 PM

epriestley requested review of this revision.May 7 2018, 8:57 PM

amckinley accepted this revision.May 7 2018, 11:24 PM

This revision is now accepted and ready to land.May 7 2018, 11:24 PM

Closed by commit rPfddb506e987f: Don't render the Maniphest edit form bottom-of-page preview panel if… (authored by epriestley). · Explain WhyMay 8 2018, 9:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editfield/

PhabricatorEditField.php

8 lines

Diff 46483

View Options

src/applications/transactions/editfield/PhabricatorEditField.php

Don't render the Maniphest edit form bottom-of-page preview panel if "Description" is locked or hiddenClosedPublicActions