Page MenuHomePhabricator

Omit "type" attribute from "<source />" tags in "<video>" to trick Chrome into playing them
ClosedPublic

Authored by epriestley on May 4 2018, 4:25 PM.

Details

Summary

Fixes T13135. See PHI633. For at least some video files with legitimate MIME type "video/quicktime", Chrome can play them but refuses to if the <source /> tag has a type="video/quicktime" attribute.

To trick Chrome into giving these videos the old college try, omit the "type" attribute. Chrome then tries to play the video, seems to realize it can, and we're back on track.

Since the "type" attribute is theoretically only useful to help browsers select among multiple different alternatives and we're only presenting one alternative, this seems likely safe and reasonable. Omitting "type" also validates. It's hard to be certain that this won't cause any collateral damage, but intuitively it seems like it should be safe and I wasn't able to identify any problems.

Test Plan
  • Watched a "video/quicktime" MP4 cat video in Chrome/Safari/Firefox.
  • See T13135 for discussion, context, and discussion of the behavior of some smaller reproduction cases.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 4 2018, 4:25 PM
epriestley requested review of this revision.May 4 2018, 4:26 PM
This revision is now accepted and ready to land.May 4 2018, 4:27 PM
This revision was automatically updated to reflect the committed changes.