Page MenuHomePhabricator

Stop computing ownership for changed paths for Very Large revisions
ClosedPublic

Authored by epriestley on Apr 30 2018, 7:15 PM.
Tags
None
Referenced Files
F13088803: D19418.diff
Thu, Apr 25, 1:34 AM
Unknown Object (File)
Thu, Apr 11, 8:45 AM
Unknown Object (File)
Thu, Mar 28, 1:00 PM
Unknown Object (File)
Wed, Mar 27, 7:51 AM
Unknown Object (File)
Wed, Mar 27, 7:51 AM
Unknown Object (File)
Wed, Mar 27, 7:51 AM
Unknown Object (File)
Wed, Mar 27, 7:50 AM
Unknown Object (File)
Wed, Mar 27, 7:50 AM
Subscribers
None

Details

Summary

Depends on D19416. Ref T13110. Ref T13130. See PHI598. When rendering a "Very Large" revision (affecting more than 1,000 files) we currently compute the package/changeset ownership map normally.

This is basically a big list of which packages own which of the files affected by the change. We use it to:

  1. Show which packages own each file in the table of contents.
  2. Show an "(Owns No Changed Paths)" hint in the reviewers list to help catch out-of-date packages that are no longer relevant.

However, this is expensive to build. We don't render the table of contents at all, so (1) is pointless. The value of (2) is very small on these types of changes, and certainly not worth spending many many seconds computing ownership.

Instead, just skip building out these relationships for very large changes.

Test Plan

Viewed a very large change with package owners; verified it no longer built package map data and rendered the package owners with no "(Owns No Changed Paths)" hints.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 30 2018, 7:23 PM
  • Remove comments which are less necessarily with more consistent code structure.
This revision was automatically updated to reflect the committed changes.