Page MenuHomePhabricator

Add a view option to disable blame in Diffusion and fix some view transition bugs
ClosedPublic

Authored by epriestley on Apr 28 2018, 1:55 PM.

Details

Summary

See PHI604. Ref T13130. Ref T13105. There's currently no way to turn blame off in Diffusion. Add a "Hide Blame" option to the "View Options" dropdown so it can be toggled off.

Also fix a couple of bugs around this: for example, if you loaded a Jupyter notebook and then switched to "Source" view, blame would incorrectly fail to activate because the original rendering of the "stage" used an asynchronous engine so willRenderRef() wasn't called to populate blame.

Test Plan
  • Viewed a source file, toggled blame off/on, reloaded page to see state stick in URL.
  • Viewed a Jupyter notebook, toggled to "Source" view, saw blame.
  • Viewed stuff in Files (no blame UI options).
  • Tried to do some invalid stuff like toggle blame on a non-blame engine (options disable properly).

Diff Detail

Repository
rP Phabricator
Branch
blame1
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 20250
Build 27486: Run Core Tests
Build 27485: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 28 2018, 1:55 PM
epriestley requested review of this revision.Apr 28 2018, 1:56 PM
amckinley accepted this revision.Apr 30 2018, 7:25 PM
This revision is now accepted and ready to land.Apr 30 2018, 7:25 PM
This revision was automatically updated to reflect the committed changes.