Paths

Table of Contentst

Differential D19414

Add a view option to disable blame in Diffusion and fix some view transition bugs
ClosedPublic
Actions

Authored by epriestley on Apr 28 2018, 1:55 PM.

Tags

None

Referenced Files

	F15456519: D19414.diff
	Sun, Mar 30, 10:20 AM

	F15455724: D19414.diff
	Sun, Mar 30, 4:26 AM

	F15452100: D19414.id46439.diff
	Sat, Mar 29, 1:46 AM

	F15448541: D19414.id46449.diff
	Fri, Mar 28, 5:30 AM

	F15436286: D19414.id.diff
	Tue, Mar 25, 1:07 PM

	F15431870: D19414.diff
	Mon, Mar 24, 3:02 PM

	F15427490: D19414.id46449.diff
	Sun, Mar 23, 2:40 PM

	F15402040: D19414.id.diff
	Mon, Mar 17, 8:16 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types
T13130: Plans: 2018 Week 17/18 Bonus Content

Commits

rPafc3099ee785: Add a view option to disable blame in Diffusion and fix some view transition…

Summary

See PHI604. Ref T13130. Ref T13105. There's currently no way to turn blame off in Diffusion. Add a "Hide Blame" option to the "View Options" dropdown so it can be toggled off.

Also fix a couple of bugs around this: for example, if you loaded a Jupyter notebook and then switched to "Source" view, blame would incorrectly fail to activate because the original rendering of the "stage" used an asynchronous engine so willRenderRef() wasn't called to populate blame.

Test Plan

Viewed a source file, toggled blame off/on, reloaded page to see state stick in URL.
Viewed a Jupyter notebook, toggled to "Source" view, saw blame.
Viewed stuff in Files (no blame UI options).
Tried to do some invalid stuff like toggle blame on a non-blame engine (options disable properly).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 28 2018, 1:55 PM

Harbormaster completed remote builds in B20250: Diff 46439.Apr 28 2018, 1:56 PM

epriestley requested review of this revision.Apr 28 2018, 1:56 PM

amckinley accepted this revision.Apr 30 2018, 7:25 PM

This revision is now accepted and ready to land.Apr 30 2018, 7:25 PM

Closed by commit rPafc3099ee785: Add a view option to disable blame in Diffusion and fix some view transition… (authored by epriestley). · Explain WhyApr 30 2018, 10:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

14 lines

src/

applications/

diffusion/

document/

DiffusionDocumentRenderingEngine.php

12 lines

files/

document/

PhabricatorDocumentEngine.php

14 lines

PhabricatorSourceDocumentEngine.php

2 lines

render/

PhabricatorDocumentRenderingEngine.php

17 lines

webroot/

rsrc/

js/

application/

files/

behavior-document-engine.js

45 lines

Diff 46449

resources/celerity/map.php

Loading...

src/applications/diffusion/document/DiffusionDocumentRenderingEngine.php

Loading...

src/applications/files/document/PhabricatorDocumentEngine.php

Loading...

src/applications/files/document/PhabricatorSourceDocumentEngine.php

Loading...

src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php

Loading...

webroot/rsrc/js/application/files/behavior-document-engine.js

Loading...