Page MenuHomePhabricator

Stop build target start times from being overwritten on reentry
ClosedPublic

Authored by epriestley on Apr 27 2018, 6:26 PM.
Tags
None
Referenced Files
F13228024: D19412.id46433.diff
Mon, May 20, 6:23 AM
F13223961: D19412.diff
Sun, May 19, 5:34 AM
F13179964: D19412.diff
Wed, May 8, 9:34 PM
Unknown Object (File)
Sat, May 4, 7:51 PM
Unknown Object (File)
Wed, May 1, 1:04 AM
Unknown Object (File)
Apr 19 2024, 7:43 PM
Unknown Object (File)
Apr 11 2024, 10:52 AM
Unknown Object (File)
Mar 27 2024, 7:48 AM
Subscribers
Restricted Owners Package

Details

Summary

See PHI615. Ref T13130. An install is reporting that "Lease Working Copy" build steps always report "Built instantly" after completion.

I'm not 100% sure that this is the fix, but I'm like 99% sure: "Lease Working Copy" build steps yield after they ask Drydock for a lease. They will later reenter doWork(), see that the lease is filled, and complete.

Right now, we reset the start time every time we enter doWork(). Instead, set it only if it hasn't been set yet.

Test Plan

This is low-risk and a bit tricky to reproduce locally, but I'll run some production builds and see what they look like.

Diff Detail

Repository
rP Phabricator
Branch
instant
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20235
Build 27465: Run Core Tests
Build 27464: arc lint + arc unit