Page MenuHomePhabricator

Stop build target start times from being overwritten on reentry
ClosedPublic

Authored by epriestley on Apr 27 2018, 6:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 7:43 PM
Unknown Object (File)
Thu, Apr 11, 10:52 AM
Unknown Object (File)
Wed, Mar 27, 7:48 AM
Unknown Object (File)
Wed, Mar 27, 7:48 AM
Unknown Object (File)
Wed, Mar 27, 7:48 AM
Unknown Object (File)
Wed, Mar 27, 7:48 AM
Unknown Object (File)
Feb 20 2024, 3:44 PM
Unknown Object (File)
Jan 29 2024, 10:27 AM
Subscribers
Restricted Owners Package

Details

Summary

See PHI615. Ref T13130. An install is reporting that "Lease Working Copy" build steps always report "Built instantly" after completion.

I'm not 100% sure that this is the fix, but I'm like 99% sure: "Lease Working Copy" build steps yield after they ask Drydock for a lease. They will later reenter doWork(), see that the lease is filled, and complete.

Right now, we reset the start time every time we enter doWork(). Instead, set it only if it hasn't been set yet.

Test Plan

This is low-risk and a bit tricky to reproduce locally, but I'll run some production builds and see what they look like.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable