Page MenuHomePhabricator
Differential D19412

Stop build target start times from being overwritten on reentry
ClosedPublic
Actions

Authored by epriestley on Apr 27 2018, 6:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 23, 1:28 AM
Unknown Object (File)
Fri, Jul 19, 3:35 AM
Unknown Object (File)
Mon, Jul 15, 11:38 AM
Unknown Object (File)
Fri, Jul 12, 11:04 AM
Unknown Object (File)
Sat, Jul 6, 11:29 PM
Unknown Object (File)
Mon, Jul 1, 6:34 PM
Unknown Object (File)
Mon, Jul 1, 6:34 PM
Unknown Object (File)
Jun 24 2024, 10:37 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
amckinley
Maniphest Tasks
T13130: Plans: 2018 Week 17/18 Bonus Content
Commits
rP5f774f7008b4: Stop build target start times from being overwritten on reentry
Summary

See PHI615. Ref T13130. An install is reporting that "Lease Working Copy" build steps always report "Built instantly" after completion.

I'm not 100% sure that this is the fix, but I'm like 99% sure: "Lease Working Copy" build steps yield after they ask Drydock for a lease. They will later reenter doWork(), see that the lease is filled, and complete.

Right now, we reset the start time every time we enter doWork(). Instead, set it only if it hasn't been set yet.

Test Plan

This is low-risk and a bit tricky to reproduce locally, but I'll run some production builds and see what they look like.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
worker/
8 lines

Diff 46433

View Options

src/applications/harbormaster/worker/HarbormasterTargetWorker.php

Loading...
Phabricator · Built by Phacility