Page MenuHomePhabricator

Fix DocumentEngine line behaviors in Diffusion
ClosedPublic

Authored by epriestley on Apr 8 2018, 1:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 13, 11:47 PM
Unknown Object (File)
Sat, Feb 8, 2:28 AM
Unknown Object (File)
Mon, Feb 3, 2:40 AM
Unknown Object (File)
Tue, Jan 28, 7:57 AM
Unknown Object (File)
Tue, Jan 28, 3:39 AM
Unknown Object (File)
Tue, Jan 28, 2:24 AM
Unknown Object (File)
Sun, Jan 26, 7:42 AM
Unknown Object (File)
Sat, Jan 25, 3:51 AM
Subscribers
None

Details

Summary

Ref T13105. Fixes some issues with line linking and highlighting under DocumentEngine:

  • Adding $1-3 to the URI didn't work correctly with query parameters.
  • Reading $1-3 from the URI didn't work correctly because Diffusion parses them slightly abnormally.
Test Plan

Clicked/dragged lines to select them. Observed URI. Reloaded page, got the right selection.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable