Page MenuHomePhabricator

Fix DocumentEngine line behaviors in Diffusion
ClosedPublic

Authored by epriestley on Apr 8 2018, 1:33 PM.

Details

Summary

Ref T13105. Fixes some issues with line linking and highlighting under DocumentEngine:

  • Adding $1-3 to the URI didn't work correctly with query parameters.
  • Reading $1-3 from the URI didn't work correctly because Diffusion parses them slightly abnormally.
Test Plan

Clicked/dragged lines to select them. Observed URI. Reloaded page, got the right selection.

Diff Detail

Repository
rP Phabricator
Branch
dfile4
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 20019
Build 27146: Run Core Tests
Build 27145: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 8 2018, 1:33 PM
epriestley requested review of this revision.Apr 8 2018, 1:34 PM
mydeveloperday accepted this revision.Apr 9 2018, 10:05 AM
This revision is now accepted and ready to land.Apr 9 2018, 10:05 AM
This revision was automatically updated to reflect the committed changes.