Page MenuHomePhabricator

Fix DocumentEngine line behaviors in Diffusion
ClosedPublic

Authored by epriestley on Apr 8 2018, 1:33 PM.
Tags
None
Referenced Files
F15451791: D19305.id46195.diff
Fri, Mar 28, 11:49 PM
F15440945: D19305.diff
Wed, Mar 26, 3:37 PM
F15433390: D19305.id46195.diff
Mon, Mar 24, 10:58 PM
Unknown Object (File)
Feb 20 2025, 1:37 AM
Unknown Object (File)
Feb 19 2025, 8:43 PM
Unknown Object (File)
Feb 13 2025, 11:47 PM
Unknown Object (File)
Feb 8 2025, 2:28 AM
Unknown Object (File)
Feb 3 2025, 2:40 AM
Subscribers
None

Details

Summary

Ref T13105. Fixes some issues with line linking and highlighting under DocumentEngine:

  • Adding $1-3 to the URI didn't work correctly with query parameters.
  • Reading $1-3 from the URI didn't work correctly because Diffusion parses them slightly abnormally.
Test Plan

Clicked/dragged lines to select them. Observed URI. Reloaded page, got the right selection.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable