Page MenuHomePhabricator

Fix DocumentEngine line behaviors in Diffusion
ClosedPublic

Authored by epriestley on Apr 8 2018, 1:33 PM.
Tags
None
Referenced Files
F19076820: D19305.diff
Mon, Dec 1, 1:41 PM
F18840606: D19305.diff
Oct 28 2025, 2:38 AM
F18822199: D19305.id.diff
Oct 23 2025, 4:54 AM
F18821799: D19305.diff
Oct 23 2025, 1:52 AM
F18811988: D19305.diff
Oct 20 2025, 6:19 AM
F18753675: D19305.id.diff
Oct 4 2025, 7:53 PM
F18735826: D19305.id46195.diff
Oct 1 2025, 3:30 AM
F18653434: D19305.diff
Sep 21 2025, 1:31 PM
Subscribers
None

Details

Summary

Ref T13105. Fixes some issues with line linking and highlighting under DocumentEngine:

  • Adding $1-3 to the URI didn't work correctly with query parameters.
  • Reading $1-3 from the URI didn't work correctly because Diffusion parses them slightly abnormally.
Test Plan

Clicked/dragged lines to select them. Observed URI. Reloaded page, got the right selection.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable