Page MenuHomePhabricator

Fix DocumentEngine line behaviors in Diffusion
ClosedPublic

Authored by epriestley on Apr 8 2018, 1:33 PM.
Tags
None
Referenced Files
F14075021: D19305.id46204.diff
Thu, Nov 21, 9:33 AM
Unknown Object (File)
Wed, Nov 20, 7:07 AM
Unknown Object (File)
Sat, Nov 9, 5:17 AM
Unknown Object (File)
Fri, Nov 8, 8:24 PM
Unknown Object (File)
Oct 19 2024, 8:56 PM
Unknown Object (File)
Oct 19 2024, 1:59 PM
Unknown Object (File)
Oct 18 2024, 5:53 PM
Unknown Object (File)
Oct 18 2024, 10:24 AM
Subscribers
None

Details

Summary

Ref T13105. Fixes some issues with line linking and highlighting under DocumentEngine:

  • Adding $1-3 to the URI didn't work correctly with query parameters.
  • Reading $1-3 from the URI didn't work correctly because Diffusion parses them slightly abnormally.
Test Plan

Clicked/dragged lines to select them. Observed URI. Reloaded page, got the right selection.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable