Page MenuHomePhabricator

Fix DocumentEngine line behaviors in Diffusion
ClosedPublic

Authored by epriestley on Apr 8 2018, 1:33 PM.
Tags
None
Referenced Files
F18212923: D19305.id.diff
Tue, Aug 19, 3:28 AM
F18204185: D19305.diff
Mon, Aug 18, 1:25 PM
F18112195: D19305.diff
Tue, Aug 12, 4:10 PM
F18095039: D19305.id.diff
Thu, Aug 7, 10:30 PM
Unknown Object (File)
Jun 3 2025, 4:16 PM
Unknown Object (File)
Jun 2 2025, 1:30 PM
Unknown Object (File)
May 31 2025, 4:22 AM
Unknown Object (File)
May 30 2025, 1:30 PM
Subscribers
None

Details

Summary

Ref T13105. Fixes some issues with line linking and highlighting under DocumentEngine:

  • Adding $1-3 to the URI didn't work correctly with query parameters.
  • Reading $1-3 from the URI didn't work correctly because Diffusion parses them slightly abnormally.
Test Plan

Clicked/dragged lines to select them. Observed URI. Reloaded page, got the right selection.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable