Page MenuHomePhabricator

Fix DocumentEngine line behaviors in Diffusion
ClosedPublic

Authored by epriestley on Apr 8 2018, 1:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 15, 8:24 AM
Unknown Object (File)
Mon, Apr 1, 10:38 AM
Unknown Object (File)
Sat, Mar 30, 4:36 PM
Unknown Object (File)
Sat, Mar 30, 4:36 PM
Unknown Object (File)
Sat, Mar 30, 4:36 PM
Unknown Object (File)
Sat, Mar 30, 4:35 PM
Unknown Object (File)
Fri, Mar 29, 8:58 AM
Unknown Object (File)
Fri, Mar 29, 8:45 AM
Subscribers
None

Details

Summary

Ref T13105. Fixes some issues with line linking and highlighting under DocumentEngine:

  • Adding $1-3 to the URI didn't work correctly with query parameters.
  • Reading $1-3 from the URI didn't work correctly because Diffusion parses them slightly abnormally.
Test Plan

Clicked/dragged lines to select them. Observed URI. Reloaded page, got the right selection.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable