Page MenuHomePhabricator

Fix DocumentEngine line behaviors in Diffusion
ClosedPublic

Authored by epriestley on Apr 8 2018, 1:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 6:26 PM
Unknown Object (File)
Sun, Dec 15, 3:43 AM
Unknown Object (File)
Fri, Dec 13, 7:00 PM
Unknown Object (File)
Sat, Dec 7, 3:15 PM
Unknown Object (File)
Mon, Dec 2, 2:50 AM
Unknown Object (File)
Fri, Nov 29, 10:35 AM
Unknown Object (File)
Thu, Nov 28, 1:23 PM
Unknown Object (File)
Thu, Nov 28, 2:14 AM
Subscribers
None

Details

Summary

Ref T13105. Fixes some issues with line linking and highlighting under DocumentEngine:

  • Adding $1-3 to the URI didn't work correctly with query parameters.
  • Reading $1-3 from the URI didn't work correctly because Diffusion parses them slightly abnormally.
Test Plan

Clicked/dragged lines to select them. Observed URI. Reloaded page, got the right selection.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable