Page MenuHomePhabricator

Fix DocumentEngine line behaviors in Diffusion
ClosedPublic

Authored by epriestley on Apr 8 2018, 1:33 PM.
Tags
None
Referenced Files
F21366752: D19305.diff
Sat, Jul 11, 3:27 PM
Unknown Object (File)
Mon, Jun 22, 8:42 AM
Unknown Object (File)
Fri, Jun 19, 7:40 PM
Unknown Object (File)
Fri, Jun 19, 6:50 PM
Unknown Object (File)
Sat, Jun 13, 2:21 AM
Unknown Object (File)
Fri, Jun 12, 7:10 AM
Unknown Object (File)
May 31 2026, 11:17 PM
Unknown Object (File)
Apr 14 2026, 4:30 PM
Subscribers
None

Details

Summary

Ref T13105. Fixes some issues with line linking and highlighting under DocumentEngine:

  • Adding $1-3 to the URI didn't work correctly with query parameters.
  • Reading $1-3 from the URI didn't work correctly because Diffusion parses them slightly abnormally.
Test Plan

Clicked/dragged lines to select them. Observed URI. Reloaded page, got the right selection.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable