Page MenuHomePhabricator

Fix DocumentEngine line behaviors in Diffusion
ClosedPublic

Authored by epriestley on Apr 8 2018, 1:33 PM.
Tags
None
Referenced Files
F14751017: D19305.id.diff
Tue, Jan 21, 12:04 PM
F14748829: D19305.diff
Tue, Jan 21, 11:04 AM
Unknown Object (File)
Wed, Jan 15, 3:12 PM
Unknown Object (File)
Fri, Jan 10, 10:43 AM
Unknown Object (File)
Sat, Jan 4, 10:38 PM
Unknown Object (File)
Tue, Dec 24, 11:45 PM
Unknown Object (File)
Dec 19 2024, 6:26 PM
Unknown Object (File)
Dec 15 2024, 3:43 AM
Subscribers
None

Details

Summary

Ref T13105. Fixes some issues with line linking and highlighting under DocumentEngine:

  • Adding $1-3 to the URI didn't work correctly with query parameters.
  • Reading $1-3 from the URI didn't work correctly because Diffusion parses them slightly abnormally.
Test Plan

Clicked/dragged lines to select them. Observed URI. Reloaded page, got the right selection.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable