Differential D19303

Fix very odd wrapping / linebreaking for Remarkup code block headers in Safari
ClosedPublic
Actions

Authored by epriestley on Apr 8 2018, 1:06 PM.

Details

Reviewers: None
Maniphest Tasks: T13120: Plans: 2018 Week 15 Bonus Content
T13118: Code block headers wrap in the dumbest way in Safari
Commits: rPfc103f71e96b: Fix very odd wrapping / linebreaking for Remarkup code block headers in Safari

Summary

Fixes T13118. Ref T13120. This construction is a little odd; I'm not entirely sure why Safari is doing what it's doing, but this appears to fix it.

Test Plan

Viewed blocks like those in T13118 in Safari. Before the patch, weird last-letter wrapping. After the patch, sensible behavior.

Diff Detail

Repository

rP Phabricator

Branch

header1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20015
Build 27140: Run Core Tests
Build 27139: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 8 2018, 1:06 PM

epriestley edited the summary of this revision. (Show Details)Apr 8 2018, 1:07 PM

epriestley added a task: T13120: Plans: 2018 Week 15 Bonus Content.

Harbormaster completed remote builds in B20015: Diff 46191.Apr 8 2018, 1:07 PM

epriestley requested review of this revision.Apr 8 2018, 1:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 8 2018, 1:16 PM

Closed by commit rPfc103f71e96b: Fix very odd wrapping / linebreaking for Remarkup code block headers in Safari (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

core/

remarkup.css

1 line

Diff 46191

View Options

resources/celerity/map.php