Paths

Table of Contentst

Differential D19268

Fix two issues with Differential updates and Owners
ClosedPublic
Actions

Authored by epriestley on Mar 29 2018, 6:29 PM.

Tags

None

Referenced Files

	F13153208: D19268.diff
	Sun, May 5, 1:22 AM

	Unknown Object (File)
	Fri, May 3, 6:40 AM

	Unknown Object (File)
	Sun, Apr 28, 5:32 AM

	Unknown Object (File)
	Thu, Apr 25, 1:15 AM

	Unknown Object (File)
	Fri, Apr 19, 7:36 PM

	Unknown Object (File)
	Apr 2 2024, 1:20 PM

	Unknown Object (File)
	Mar 31 2024, 11:27 AM

	Unknown Object (File)
	Mar 31 2024, 10:39 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13114: Plans: 2018 Week 13 Bonus Content
Commits: rP79154455437b: Fix two issues with Differential updates and Owners

Summary

Followup fix for D19267, which didn't work correctly with new revision creation.
Followup fix for changes in T11015. Some of the querying logic was still handling "/x.y" and "/x.y/" differently. Instead, normalize consistently to "/x.y/"

Test Plan

Created a new revision cleanly.
Created a package owning only a example.txt file and saw Differential find it as an owning package in the table of contents.

Diff Detail

Repository

Branch

owners1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19945
Build 27037: Run Core Tests
Build 27036: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 29 2018, 6:29 PM

Harbormaster completed remote builds in B19945: Diff 46124.Mar 29 2018, 6:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2018, 6:30 PM

epriestley requested review of this revision.

Closed by commit rP79154455437b: Fix two issues with Differential updates and Owners (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

(See also PHI516.)

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionUpdateTransaction.php

4 lines

owners/

storage/

PhabricatorOwnersPackage.php

21 lines

Diff 46124

src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php

Loading...

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...