Differential D19267

Make updating a revision with the same active diff a no-op
ClosedPublic
Actions

Authored by epriestley on Mar 29 2018, 4:54 PM.

Details

Reviewers: None
Maniphest Tasks: T13114: Plans: 2018 Week 13 Bonus Content
Commits: rP93cb6e3bdeb0: Make updating a revision with the same active diff a no-op

Summary

Ref T13114. See PHI515. Updating a revision with the same, currently active diff became an error at some point (probably D19175). This is inconsistent; make it an allowable no-op instead.

Test Plan

Updated a revision's diff via Conduit.
Updated to the same diff, no-op.
Tried to update a different revision, error ("already attached elsewhere").
Updated with a different diff.
Tried to update with the original diff, error ("previously attached version").

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 29 2018, 4:54 PM

Harbormaster completed remote builds in B19943: Diff 46122.Mar 29 2018, 4:55 PM

epriestley requested review of this revision.Mar 29 2018, 4:55 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2018, 4:59 PM

Closed by commit rP93cb6e3bdeb0: Make updating a revision with the same active diff a no-op (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D19268: Fix two issues with Differential updates and Owners.Mar 29 2018, 6:29 PM

epriestley mentioned this in rP79154455437b: Fix two issues with Differential updates and Owners.Mar 29 2018, 6:32 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionUpdateTransaction.php

27 lines

Diff 46123

View Options

src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php

Make updating a revision with the same active diff a no-opClosedPublicActions