Page MenuHomePhabricator
Differential D19254

Add an abstract "Text" document engine and a "Source" document engine
ClosedPublic
Actions

Authored by epriestley on Mar 23 2018, 2:41 PM.
Tags
None
Referenced Files
F21420081: D19254.diff
Wed, Jul 29, 10:24 PM
Unknown Object (File)
Wed, Jul 1, 5:12 AM
Unknown Object (File)
Jun 30 2026, 1:24 AM
Unknown Object (File)
Jun 27 2026, 11:54 PM
Unknown Object (File)
Jun 25 2026, 4:31 PM
Unknown Object (File)
Jun 25 2026, 11:51 AM
Unknown Object (File)
Jun 23 2026, 5:03 AM
Unknown Object (File)
Jun 22 2026, 9:02 PM
View All Files
Subscribers
None

Details

Reviewers
mydeveloperday
Maniphest Tasks
T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits
rPd2727d24da6e: Add an abstract "Text" document engine and a "Source" document engine
Summary

Ref T13105. Allow normal text files to be rendered as documents, and add a "source code" rendering engine.

Test Plan

Viewed some source code.

Diff Detail

Repository
rP Phabricator
Branch
docu4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19914
Build 26993: Run Core Tests
Build 26992: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
4 lines
applications/
files/
document/
30 lines
33 lines
webroot/
rsrc/
css/
layout/
20 lines
phui/
4 lines

Diff 46096

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/document/PhabricatorSourceDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorTextDocumentEngine.php

Loading...
View Options

webroot/rsrc/css/layout/phabricator-source-code-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...
Phabricator · Built by Phacility